changed default type of certificate secret to kubernetes.io/tls
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
|
/invite @timuthy |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
timuthy
reviewed
May 17, 2021
MartinWeindel
force-pushed
the
change-secret-type-tls
branch
from
de2b97e
to
a54efaf
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
mandelsoft
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The default secret type of certificate secrets is changed from
Opaquetokubernetes.io/tlsto avoid problems with some client applications like contour.Already existing certificate secrets will keep their original type, as the secret type is immutable. To change the secret type the secret has to been deleted and a reconciliation of the certificate has to be triggered either by restarting the cert-controller-manager or recreating the certificate object.
Which issue(s) this PR fixes:
Fixes #73
Special notes for your reviewer:
Release note: