Skip to content

fix panic if an ingress spec does not provide tls hosts #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2019
Merged

fix panic if an ingress spec does not provide tls hosts #7

merged 1 commit into from
Nov 19, 2019

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #6

Release note:

fix for "Panic if ingress spec.tls.hosts not specified" (issue #6)

@MartinWeindel
fix "panic: runtime error: index out of range" if an ingress manifest…
80a07c0 
… does

not provide tls hosts

```improvement operator
fix for "Panic if ingress spec.tls.hosts not specified" (issue #6)
```
@MartinWeindel MartinWeindel requested a review from a team as a code owner November 19, 2019 09:45
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 19, 2019
@MartinWeindel MartinWeindel merged commit aa3e852 into master Nov 19, 2019
@MartinWeindel MartinWeindel deleted the fix-issue6 branch November 19, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic if ingress spec.tls.hosts not specified
2 participants
@MartinWeindel @gardener-robot-ci-1