Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove short name for issuer #147

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Remove short name for issuer #147

merged 1 commit into from
Oct 31, 2023

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes gardener/gardener-extension-shoot-cert-service#208

Special notes for your reviewer:

Release note:

Remove `issuer` short name for issuer CustomResourceDefinition as it is the same as the singular.

@MartinWeindel MartinWeindel requested a review from a team as a code owner October 31, 2023 13:02
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 31, 2023
@MartinWeindel MartinWeindel merged commit a865a84 into master Oct 31, 2023
7 checks passed
@MartinWeindel MartinWeindel deleted the fix/issuer-short-name branch October 31, 2023 13:09
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/api-change API change with impact on API users needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Short name for Issuer CRD is invalid
3 participants
@MartinWeindel @gardener-robot-ci-3 @gardener-robot