Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for preferred chains #137

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Support for preferred chains #137

merged 1 commit into from
Aug 24, 2023

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
If the CA (i.e. the ACME server) offers multiple certificate chains, you can select the chain with setting the optional preferredChain field in the certificate spec.
The value is the Subject Common Name of the issuer. If no match, the default offered chain will be used.
For sources like Ingress and Service a new annotation cert.gardener.cloud/preferred-chain was added as well.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Support for preferred chains to select a certificate chain returned for a certificate request from the ACME server

@MartinWeindel MartinWeindel requested a review from a team as a code owner August 24, 2023 06:48
@CLAassistant
Copy link

CLAassistant commented Aug 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gardener-robot gardener-robot added needs/review Needs review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 24, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 24, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 24, 2023
@MartinWeindel MartinWeindel merged commit 9fb29fb into master Aug 24, 2023
1 check passed
@MartinWeindel MartinWeindel deleted the enh/preferred-chain branch August 24, 2023 07:20
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 24, 2023
@MartinWeindel MartinWeindel mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinWeindel @CLAassistant @gardener-robot-ci-1 @gardener-robot