Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update charts CRDs to latest version #133

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Update charts CRDs to latest version #133

merged 3 commits into from
Aug 17, 2023

Conversation

acumino
Copy link
Member

@acumino acumino commented Aug 17, 2023 •
edited
Loading

What this PR does / why we need it:

This PR enhances the make generate so it also copies the latest generated CRDs to the charts directory. Also it drops the CRDs for version apiextensions.k8s.io/v1beta1 as apiextensions.k8s.io/v1 is supported from Kubernetes version 1.16 and support for apiextensions.k8s.io/v1beta1 is dropped in 1.22.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Support of CRDs of version `apiextensions.k8s.io/v1beta1` is dropped.

@acumino acumino requested a review from a team as a code owner August 17, 2023 08:02
@gardener-robot gardener-robot added needs/review Needs review size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Aug 17, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 17, 2023
@acumino acumino changed the title Crds gen Update charts CRDs to latest version Aug 17, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 17, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 17, 2023
@acumino
Copy link
Member Author

acumino commented Aug 17, 2023

/invite @timuthy @MartinWeindel

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 17, 2023
MartinWeindel
MartinWeindel approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Aug 17, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 17, 2023
@MartinWeindel MartinWeindel merged commit 3bdebed into gardener:master Aug 17, 2023
1 check passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 17, 2023
@acumino acumino deleted the crds-gen branch August 17, 2023 10:58
@acumino acumino mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

@timuthy timuthy Awaiting requested review from timuthy

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@acumino @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot