Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cert.gardener.cloud/issuer annotation for shoot issuers #132

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix cert.gardener.cloud/issuer annotation for shoot issuers #132

merged 1 commit into from
Jul 13, 2023

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Jul 13, 2023 •
edited
Loading

What this PR does / why we need it:
For custom issuers you have to specify the annotation cert.gardener.cloud/issuer annotation for managed resources like Ingress and Service.
For shoot issuers (option --allow-target-issuers) you have to provide both namespace and name in this case, but the source controller did not deal correctly with it.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Allow to specify shoot issuer in annotation `cert.gardener.cloud/issuer annotation` with format `namespace/name`.

Updated builder image from `golang:1.20.5` to `golang:1.20.6`

@MartinWeindel MartinWeindel requested a review from a team as a code owner July 13, 2023 10:35
@gardener-robot gardener-robot added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 13, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 13, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 13, 2023
@MartinWeindel MartinWeindel merged commit a3e069a into master Jul 13, 2023
1 check passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 13, 2023
@MartinWeindel MartinWeindel deleted the fix/source-shoot-issuer branch July 13, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot