Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt NetworkPolicys #128

Merged
merged 1 commit into from
May 11, 2023
Merged

Adapt NetworkPolicys #128

merged 1 commit into from
May 11, 2023

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area security networking
/kind enhancement

What this PR does / why we need it:
This PR adapts the NetworkPolicys as following:

  • egress traffic to DNS and to the runtime kube-apiserver is allowed
  • egress traffic to public networks (to reach Let's Encrypt API)

Release note:

The Helm chart is now adapted such that it works well in garden cluster with enabled `NetworkPolicy` protection (default since `gardener/gardener@v1.71` when garden cluster is managed by `gardener-operator`).

@rfranzke rfranzke requested a review from a team as a code owner May 11, 2023 11:58
@gardener-robot gardener-robot added area/networking Networking related area/security Security related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 11, 2023
MartinWeindel
MartinWeindel approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MartinWeindel MartinWeindel merged commit a5fb009 into gardener:master May 11, 2023
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging status/closed Issue is closed (either delivered or triaged) and removed needs/review Needs review labels May 11, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2023
@rfranzke rfranzke deleted the enh/netpols branch May 11, 2023 12:37
@MartinWeindel MartinWeindel mentioned this pull request May 11, 2023
Merged
@rfranzke
Copy link
Member Author

When do you plan the next release containing this PR?

@MartinWeindel
Copy link
Member

When do you plan the next release containing this PR?

The plan is to address #130 and then releasing in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/networking Networking related area/security Security related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfranzke @MartinWeindel @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot