Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for secret labels #123

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Support for secret labels #123

merged 1 commit into from
Mar 27, 2023

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
The certificate spec can contain an optional section secretLabels to specify labels for the certificate secret.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The certificate spec can contain an optional section `secretLabels` to specify labels for the certificate secret.

@MartinWeindel MartinWeindel requested a review from a team as a code owner March 27, 2023 10:04
@gardener-robot gardener-robot added needs/review Needs review size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Mar 27, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 27, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 27, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 27, 2023
@MartinWeindel MartinWeindel merged commit f69075d into master Mar 27, 2023
@MartinWeindel MartinWeindel deleted the secret-labels branch March 27, 2023 12:11
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 27, 2023
@MartinWeindel MartinWeindel added the area/ipcei IPCEI (Important Project of Common European Interest) label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot