Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Adds 'gardenctl target' and 'gardenctl get' completions #57

Merged

Conversation

plkokanov
Copy link
Contributor

@plkokanov plkokanov commented Feb 6, 2019

Note
The completions depend on grep and awk.
This PR requires the following spf13/cobra PR: spf13/cobra#730 and an update to the new cobra version containing that PR. Otherwise the required __custom_func which does the target and get autocompletions will overshadow __custom_complete functions from other programs which use spf13/corba to autogenerate bash completions (e.g. kubectl)

Copy link
Contributor

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've tested it with the newest cobra version. Will update it as well. Thanks

@DockToFuture DockToFuture reopened this Feb 6, 2019
@DockToFuture DockToFuture merged commit 37074a3 into gardener-attic:master Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants