Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

enable gardenctl logs for some components while targeting the control plane #471

Conversation

neo-liang-sap
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #436

Special notes for your reviewer:

Release note:

enable gardenctl logs for some components while targeting the control plane

@neo-liang-sap neo-liang-sap requested a review from a team as a code owner November 26, 2020 06:56
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 26, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 26, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 26, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 27, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 27, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 1, 2020
@neo-liang-sap
Copy link
Contributor Author

PR included fix of #470 - ready for review

@neo-liang-sap
Copy link
Contributor Author

Per discussion in planning mtg i will merge this PR

@neo-liang-sap neo-liang-sap merged commit 95e8ff5 into gardener-attic:master Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs for controlplane components should not require a shoot to be targeted
4 participants