Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

remove double dash when using gardenctl aws/gcloud/az/openstack/kubectl #428

Merged
merged 1 commit into from
Nov 10, 2020
Merged

remove double dash when using gardenctl aws/gcloud/az/openstack/kubectl #428

merged 1 commit into from
Nov 10, 2020

Conversation

tedteng
Copy link
Contributor

@tedteng tedteng commented Nov 6, 2020

What this PR does / why we need it:

remove double dash when using gardenctl aws/gcloud/az/openstack/kubectl

Which issue(s) this PR fixes:
Fixes #427

Special notes for your reviewer:

Release note:

remove double dash when using gardenctl aws/gcloud/az/openstack/kubectl

@tedteng tedteng requested a review from a team as a code owner November 6, 2020 05:40
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 6, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 6, 2020
dansible
dansible previously approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@dansible dansible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👍

@gardener-robot gardener-robot removed the needs/review Needs review label Nov 9, 2020
@dansible dansible dismissed their stale review November 9, 2020 17:36

seems to not be working in all cases

dansible
dansible approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@dansible dansible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the back and forth - it was a mistake on my part. Looks good from local testing 👍

@neo-liang-sap neo-liang-sap merged commit 87a8530 into gardener-attic:master Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dansible dansible dansible approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

calling aws/gcloud/az/openstack/kubectl directly without useing -- to parse the flags
5 participants
@tedteng @dansible @neo-liang-sap @gardener-robot-ci-2 @gardener-robot