Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

gardenctl diag command #413

Merged
merged 1 commit into from
Nov 10, 2020
Merged

gardenctl diag command #413

merged 1 commit into from
Nov 10, 2020

Conversation

neo-liang-sap
Copy link
Contributor

What this PR does / why we need it:
after targeting a shoot, gardenctl diag command prints out diagnostic information of the shoot
Which issue(s) this PR fixes:
Fixes #407

Special notes for your reviewer:

Release note:

`gardenctl diag` command prints out diagnostic information of a shoot

@neo-liang-sap neo-liang-sap requested a review from a team as a code owner October 28, 2020 01:33
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 28, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 28, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 28, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 28, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 28, 2020
@dansible
Copy link
Contributor

dansible commented Oct 30, 2020 •
edited
Loading

I am getting this runtime panic when running it against a shoot in openstack:

Workers:

  worker name:worker-ywf3s
  min/max/max unavailable/max surge: 1:3-0-1
  machine image name:coreos
  machine image version:2135.6.0
  machine type:m1.medium
  volume:
    volume name:panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x208a255]

goroutine 1 [running]:
github.com/gardener/gardenctl/pkg/cmd.getShootInformation(0xc00020ee00, 0x2583b00, 0xc0002f1540)
	/Users/i871011/0-proj/_gardener/gardenctl/pkg/cmd/diag.go:102 +0x1755
github.com/gardener/gardenctl/pkg/cmd.NewDiagCmd.func1(0xc0004422c0, 0x2f87ea0, 0x0, 0x0, 0x0, 0x0)
	/Users/i871011/0-proj/_gardener/gardenctl/pkg/cmd/diag.go:47 +0xd0
github.com/spf13/cobra.(*Command).execute(0xc0004422c0, 0x2f87ea0, 0x0, 0x0, 0xc0004422c0, 0x2f87ea0)
	/Users/i871011/0-proj/_gardener/gardenctl/vendor/github.com/spf13/cobra/command.go:840 +0x47c
github.com/spf13/cobra.(*Command).ExecuteC(0x2f443c0, 0x1d, 0xc0000bfc00, 0x36)
	/Users/i871011/0-proj/_gardener/gardenctl/vendor/github.com/spf13/cobra/command.go:945 +0x336
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/i871011/0-proj/_gardener/gardenctl/vendor/github.com/spf13/cobra/command.go:885
github.com/gardener/gardenctl/pkg/cmd.Execute()
	/Users/i871011/0-proj/_gardener/gardenctl/pkg/cmd/root.go:113 +0x3ab
main.main()
	/Users/i871011/0-proj/_gardener/gardenctl/cmd/gardenctl/main.go:20 +0x25
exit status 2

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 3, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 3, 2020
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 3, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 3, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 3, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 3, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 3, 2020
@neo-liang-sap
Copy link
Contributor Author

the panic error is fixed and all output is "tablized"
image

dansible
dansible approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@dansible dansible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Ty!!

@gardener-robot gardener-robot removed the needs/review Needs review label Nov 9, 2020
@neo-liang-sap neo-liang-sap merged commit d02ae46 into gardener-attic:master Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dansible dansible dansible approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement gardenctl diag like what we have in gardener-robot ./diag shoot_url
6 participants
@neo-liang-sap @dansible @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot