This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
gardenctl diag command #413
Merged
neo-liang-sap
merged 1 commit into
gardener-attic:master
from
neo-liang-sap:gardenctl-diag
Nov 10, 2020
Merged
gardenctl diag command #413
neo-liang-sap
merged 1 commit into
gardener-attic:master
from
neo-liang-sap:gardenctl-diag
Nov 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
Needs review
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
labels
Oct 28, 2020
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 28, 2020
gardener-robot-ci-1
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 28, 2020
neo-liang-sap
force-pushed
the
gardenctl-diag
branch
from
October 28, 2020 01:40
7a3e52e
to
088b58e
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 28, 2020
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 28, 2020
I am getting this runtime panic when running it against a shoot in openstack:
|
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 3, 2020
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 3, 2020
gardener-robot
added
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
and removed
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
labels
Nov 3, 2020
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 3, 2020
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 3, 2020
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 3, 2020
neo-liang-sap
force-pushed
the
gardenctl-diag
branch
from
November 3, 2020 09:45
b840497
to
044d93a
Compare
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 3, 2020
dansible
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Ty!!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/second-opinion
Needs second review by someone else
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
after targeting a shoot,
gardenctl diag
command prints out diagnostic information of the shootWhich issue(s) this PR fixes:
Fixes #407
Special notes for your reviewer:
Release note: