Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

inspect and refactor ls.go #410

Merged
merged 4 commits into from
Oct 28, 2020
Merged

inspect and refactor ls.go #410

merged 4 commits into from
Oct 28, 2020

Conversation

andrei-panov
Copy link
Contributor

@andrei-panov andrei-panov commented Oct 26, 2020 •
edited by dansible
Loading

What this PR does / why we need it:
code cleanup
Which issue(s) this PR fixes:
Fixes #328

Special notes for your reviewer:
ls.go only inspected with this PR. No additional sanitization is required. All changes should be served as refactoring.

Release note:

new tested method `cmd.PrintoutObject` can be used to print structures in YAML or JSON format to passed io.Writer

@andrei-panov andrei-panov requested a review from a team as a code owner October 26, 2020 11:03
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 26, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 26, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 26, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 26, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 26, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 26, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 26, 2020
dansible
dansible previously approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@dansible dansible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gardener-robot gardener-robot removed the needs/review Needs review label Oct 27, 2020
@dansible dansible dismissed their stale review October 27, 2020 12:31

missing release note

@dansible
Copy link
Contributor

Hi @andrei-panov, thanks for the PR. The changes look good 👍

Can you add a release note to the PR description as in the template? This should include info for the PrintoutObject function and testing

petersutter
petersutter approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Oct 27, 2020
@tedteng tedteng mentioned this pull request Oct 28, 2020
Merged
@CLAassistant
Copy link

CLAassistant commented Oct 28, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 28, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 28, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 28, 2020
@andrei-panov
Copy link
Contributor Author

@dansible all planned changes for the related issue are in place, please approve. The release noted updated.

@dansible dansible merged commit c35fdeb into master Oct 28, 2020
@dansible dansible deleted the issue-328-sanitize-input branch October 28, 2020 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petersutter petersutter petersutter approved these changes

@dansible dansible dansible approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanitize user input in ls.go & operate.go
8 participants
@andrei-panov @dansible @CLAassistant @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot