This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
add shoot target check when target.Stack() length >= 3 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
reviewed/ok-to-test
neo-liang-sap
changed the title
neo-liang-sap
force-pushed
the
make-az-error-readable
branch
from
588bd89
to
37d5a7a
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
neo-liang-sap
force-pushed
the
make-az-error-readable
branch
from
37d5a7a
to
f3c3cf6
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
neo-liang-sap
changed the title
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sometimes ago we only have
garden/seed/project/shootin kinds of target, so when len(target.Stack())>=3, there must be one shoot targeted.Now there's one new kind of
namespacein kinds of target, so when len(target.Stack())>=3 , shoot might not be targeted, which might causing some command fail (e.g.gardenctl azrelated commands)Which issue(s) this PR fixes:
Fixes #196
Special notes for your reviewer:
This error was found in executing
gardenctl azbut also found across the whole project, so refactor them all togetherRelease note: