This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
add support for target url or target -u with dashboard url #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neo-liang-sap
requested review from
DockToFuture and
ialidzhikov
as code owners
April 20, 2020 08:21
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Apr 20, 2020
neo-liang-sap
force-pushed
the
target-url
branch
from
April 20, 2020 08:25
4fe7ec4
to
ed2c25b
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Apr 20, 2020
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Apr 20, 2020
rfranzke
reviewed
Apr 20, 2020
neo-liang-sap
force-pushed
the
target-url
branch
from
April 21, 2020 04:01
ed2c25b
to
be32fa0
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Apr 21, 2020
neo-liang-sap
force-pushed
the
target-url
branch
from
April 21, 2020 09:38
be32fa0
to
19cf046
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Apr 21, 2020
neo-liang-sap
force-pushed
the
target-url
branch
from
April 21, 2020 09:41
19cf046
to
7973db1
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Apr 21, 2020
neo-liang-sap
force-pushed
the
target-url
branch
from
April 21, 2020 09:42
7973db1
to
35ed41e
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Apr 21, 2020
Hi @petersutter , |
petersutter
reviewed
Apr 21, 2020
neo-liang-sap
force-pushed
the
target-url
branch
from
April 21, 2020 12:00
35ed41e
to
510777c
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Apr 21, 2020
petersutter
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more minor change, otherwise lgtm
thnx!
neo-liang-sap
force-pushed
the
target-url
branch
from
April 21, 2020 12:22
510777c
to
9ed975f
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Apr 21, 2020
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Apr 21, 2020
@neo-liang-sap I have also updated your description and release note. PTAL |
thanks @petersutter for fixing the description! |
DockToFuture
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enable
gardenctl target dashboardUrl dashboard_url
orgardenctl target -u dashboard_url
for directly targeting garden and shootThis requires your (virtual) garden config to have
dashboardUrl
field set.E.g.
Which issue(s) this PR fixes:
Fixes #188
Special notes for your reviewer:
the url could be in following two formats:
Release note: