feat(openshift): Run and Test actions #4730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orzelius
reviewed
Jul 3, 2023
| @@ -233,6 +233,11 @@ export async function getSystemNamespace( | |||
| api?: KubeApi | |||
| ): Promise<string> { | |||
| const namespace = { name: provider.config.gardenSystemNamespace } | |||
| // HACK: in OpenShift, we work in only one namespace, the one assigned to the developer | |||
| if (!namespace.name) { | |||
| log.warn("No system namespace found, using the current namespace. If you are using OpenShift, ignore this warning.") | |||
There was a problem hiding this comment.
Is there a reason to print the message in the first place for openshift users?
There was a problem hiding this comment.
This is within the generic kubernetes code, and we don't necessarily know here if we are running OpenShift or not. Something to fix later when we have the OpenShfit provider in a better shape and can propagate the information around
There was a problem hiding this comment.
I think the ctx passed here has that data though
There was a problem hiding this comment.
Currently, we don't have a proper OpenShift provider context - it is using the KubernetesProvider and its context under the hood. Definitely something we need to improve later!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4626
Fixes #4627
Special notes for your reviewer: