fix(cloud): send "sessionFailed" event if result has errors

Previously we'd send a "sessionCompleted" event which caused Cloud to
display the wrong command status.

core/src/cloud/api.ts

@@ -94,8 +94,8 @@ export type ApiFetchResponse<T> = T & {
 
 // TODO: Read this from the `api-types` package once the session registration logic has been released in Cloud.
 export interface CloudSessionResponse {
-  environmentId: number
-  namespaceId: number
+  environmentId: string
+  namespaceId: string
   shortId: string
 }
 

core/src/cloud/buffered-event-stream.ts

@@ -83,8 +83,8 @@ interface ApiBatchBase {
 
 export interface ApiEventBatch extends ApiBatchBase {
   events: StreamEvent[]
-  environmentId?: number
-  namespaceId?: number
+  environmentId?: string
+  namespaceId?: string
   // TODO: Remove the `environment` and `namespace` params once we no longer need to support Cloud/Enterprise
   // versions that expect them.
   environment: string

core/src/commands/base.ts

@@ -420,7 +420,11 @@ export abstract class Command<A extends Parameters = {}, O extends Parameters =
             parentSessionId || undefined
           )
 
-          cloudEventStream.emit("sessionCompleted", {})
+          if (allErrors.length > 0) {
+            cloudEventStream.emit("sessionFailed", {})
+          } else {
+            cloudEventStream.emit("sessionCompleted", {})
+          }
         } catch (err) {
           analytics?.trackCommandResult(
             this.getFullName(),

core/src/events/events.ts

@@ -156,11 +156,11 @@ export type GraphResultEventPayload = Omit<GraphResult, "result" | "task" | "dep
 export interface CommandInfoPayload extends CommandInfo {
   // Contains additional context for the command info available during init
   environmentName: string
-  environmentId: number | undefined
+  environmentId?: string
   projectName: string
   projectId: string
   namespaceName: string
-  namespaceId: number | undefined
+  namespaceId?: string
   coreVersion: string
   vcsBranch: string
   vcsCommitHash: string