Skip to content

Conversation

@anthonykhoa
Copy link
Collaborator

@anthonykhoa anthonykhoa commented Oct 7, 2020

The websites needs to display a tutorial, as well as all the ability to create a database for Arango.
This PR cannot be merged until we have a production arango database.
This PR will:

  • Include a tutorial for Arango
  • Update relevant back-end files needed to enable create my database button for on the Arango tutorial page
  • Update tutorial to display an instead of a before database names that start with a vowel

Screen Shot 2020-10-07 at 11 44 41 AM

Screen Shot 2020-10-07 at 11 25 20 AM

Screen Shot 2020-10-07 at 11 25 41 AM

Screen Shot 2020-10-07 at 11 25 47 AM

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #240 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          481       494   +13     
  Branches        50        55    +5     
=========================================
+ Hits           481       494   +13     
Impacted Files Coverage Δ
database/arango/arango.js 100.00% <100.00%> (ø)
database/elasticsearch/elastic.js 100.00% <100.00%> (ø)
lib/util.js 100.00% <100.00%> (ø)
src/routes/renderRoutes.js 100.00% <100.00%> (ø)
src/routes/userRoutes.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624355a...290aafa. Read the comment docs.

@anthonykhoa anthonykhoa changed the title Frontend [DNM]Frontend Oct 7, 2020
@anthonykhoa anthonykhoa changed the title [DNM]Frontend [DNM] closes #238 - Display tutorial for Arango Oct 7, 2020
@anthonykhoa anthonykhoa marked this pull request as ready for review October 7, 2020 18:50
Comment on lines 9 to 13
const dbHost = {
Postgres: "learndatabases.dev",
Elasticsearch: "elastic.learndatabases.dev",
Arango: process.env.ARANGO_URL,
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be process.env.HOST for postgres/sequelize and process.env.ES_HOST for elastic?

Copy link
Collaborator Author

@anthonykhoa anthonykhoa Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right -- I simply copy and pasted the links used for dbHost that the last person that touched this file used. It should be process.env.ES_HOST for elastic, and the testing files should change to reflect that too. Thank you, I will make those changes! We have to update our environment variables for postgres and elasticsearch on our CI in order for tests to pass.

@anthonykhoa anthonykhoa changed the title [DNM] closes #238 - Display tutorial for Arango closes #238 - Display tutorial for Arango Oct 17, 2020
@anthonykhoa anthonykhoa merged commit 2919eef into garageScript:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants