-
Notifications
You must be signed in to change notification settings - Fork 11
closes #238 - Display tutorial for Arango #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lean duplicated code
… in sendFEtch functin
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 481 494 +13
Branches 50 55 +5
=========================================
+ Hits 481 494 +13
Continue to review full report at Codecov.
|
| const dbHost = { | ||
| Postgres: "learndatabases.dev", | ||
| Elasticsearch: "elastic.learndatabases.dev", | ||
| Arango: process.env.ARANGO_URL, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be process.env.HOST for postgres/sequelize and process.env.ES_HOST for elastic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right -- I simply copy and pasted the links used for dbHost that the last person that touched this file used. It should be process.env.ES_HOST for elastic, and the testing files should change to reflect that too. Thank you, I will make those changes! We have to update our environment variables for postgres and elasticsearch on our CI in order for tests to pass.
The websites needs to display a tutorial, as well as all the ability to create a database for Arango.
This PR cannot be merged until we have a production arango database.
This PR will:
create my databasebutton for on the Arango tutorial pageaninstead ofabefore database names that start with a vowel