-
Notifications
You must be signed in to change notification settings - Fork 11
Logging module #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Logging module #24
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b9fe613
first wrote roughly logging module
f96e5e4
add filename in logs
19ab53c
I'll look these on the bus going to work
5992dfa
moved logging module to lib folder
3b80f6c
removed leftover
891b9f7
added package.json
096f918
fixed logging module
5542010
first wrote roughly log.test.js(not working yet)
82825a4
added timestamp and changed its format to standard one
widesunryu 1d8f5bd
fixed package.json
widesunryu 493e147
pulled upstream master and merged package.json
10647e8
Merge branch 'loggingModule' of github.com:kimong1/databases into log…
8b90b71
fixing log.test.js is on progress
590fee5
It says createLogger is not a mock. Why?
ddfcebc
fixed log.test.js and it works now
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
const {createLogger, format, transports} = require('winston') | ||
|
||
module.exports = (file) => { | ||
const logger = createLogger({ | ||
format: format.combine( | ||
format.timestamp({format:'YYYY-MM-DD HH:mm:ss'}), | ||
format.label({ | ||
label: file | ||
}), | ||
format.colorize(), | ||
format.printf( | ||
info => `${info.timestamp} ${info.level} [${info.label}]: ${info.message}` | ||
) | ||
), | ||
transports : [ | ||
new transports.Console() | ||
] | ||
}) | ||
return logger | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
jest.mock('winston') | ||
const winston = require('winston') | ||
winston.createLogger = jest.fn().mockImplementation(() => { | ||
return { | ||
error: () => {}, | ||
warn: () => {}, | ||
info: () => {} | ||
} | ||
}) | ||
winston.format = { | ||
combine: () => {}, | ||
timestamp: () => {}, | ||
label: () => {}, | ||
colorize: () => {}, | ||
printf: () => {} | ||
} | ||
winston.transports.Console = function(){} | ||
|
||
describe('Testing log.js', () => { | ||
beforeEach(() => { | ||
jest.clearAllMocks() | ||
hoiekim marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}) | ||
it('should call winston.createLogger when log is required', () => { | ||
const logger = require('./log')(__filename) | ||
expect(winston.createLogger).toHaveBeenCalled() | ||
}) | ||
songz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.