Use TypedElement.type for Lifeline and other types #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
type.name takes precedence over typeValue. This now works for lifeline, but also classes and properties.
amolenaar
changed the title
Message should not be horizontal in that cases.
amolenaar
commented
Mar 23, 2024
danyeaw
added
fix
danyeaw
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Lifeline should show name of represented type (
ConnectableElement)Issue Number: Fixes #2514
What is the new behavior?
Show represented name and type.
In addition I changed all cases where
TypedElement.typeValueis used to also check forTypedElement.type.name. In all casestypetakes precedence overtypeValue, since type is actually linked to a model element andtypeValueis something specifically added for Gaphor.Also fixed messages: when attached to "life lines" without an actual lifeline, they act as a communication diagram.
In this case, lines so not need to be horizontal.
Does this PR introduce a breaking change?
Other information
It would be nice if the Property Editor also shows settings for elements selected in the Model Browser. E.g. now it's not possible to change the attribute type easily.