Fix undoing pasted items #3075
Merged
Fix undoing pasted items #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Connected items are no longer unlinked directly * Connectors are smarter at finding out the diagram The latter is needed, since a diagram can be set to None before connections are actually removed from the diagram.
amolenaar
commented
Feb 3, 2024
Comment on lines
-114
to
-115
| for item in connecting_items: | ||
| item.unlink() |
There was a problem hiding this comment.
by removing those lines, connecting items are no longer automatically removed.
However, we shouldn't do this here anyway, since it can interfere with actions performed in when undoing a transaction.
danyeaw
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
Nice fix @amolenaar. I think leaving the relationships is fine because a user can explicitly remove those as well if that's what they are trying to do.
danyeaw
added
fix
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Create elements, copy and paste them, then hit undo. Bang!
Issue Number: fixes #2895
What is the new behavior?
You can safely undo a paste action.
Does this PR introduce a breaking change?
Deleting items in a diagram behaves different.
Other information