Fix Activity Swimlanes aren't visible #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Box shape had a `__len__` attribute, that rendered the Box false-ish.
danyeaw
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Great fix @amolenaar!
I'm not sure if this is related to this bug, but shouldn't be make the default size of Swimlanes a bit larger?
danyeaw
added
fix
|
That should not be too hard. |
3 tasks
|
This is also a regression. In 2.22.1 the lanes are wider by default. |
Add some dummy boxes to ensure a minimal width.
|
@danyeaw I added some dummy boxes to ensure a minimal width. This broke since empty boxes no longer yield false in if-stamenets, hence the update code of The proper solution is to break it up in shapes, for text and the actual swimlanes. I think we lack a few features there still. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Any item with a Box shape and no children, does not draw.
This goes for Swimlanes (partitions), but also rectangles.
Issue Number: #2988
What is the new behavior?
Swimlanes are shown again.
Does this PR introduce a breaking change?
Other information