Wrap element name #2889
Merged
Wrap element name #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property can have 2 values: * normal: text is wrapped depending on the element width * nowrap: text is all on one line
This allows text to be rendered on multiple lines if a custom width is provided to the Text object.
amolenaar
force-pushed
the
wrap-element-name
branch
2 times, most recently
from
57df46c
to
dba9346
Compare
This allows us to shape text to be wrapped if the styling allows for it.
Instead, determine the text size through style properties.
amolenaar
force-pushed
the
wrap-element-name
branch
from
dba9346
to
0926269
Compare
Now the label can be placed nicely under the icon.
This was
linked to
issues
Dec 2, 2023
danyeaw
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
This is soo nice 🤩! This is a great improvement, thanks @amolenaar!
danyeaw
added
feature
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Text is not wrapped for a lot of elements
Issue Number: #2813, #2777
What is the new behavior?
Text can be wrapped or non-wrapped by setting the
white-spaceCSS property to eithernormal(default) ornowrap.Does this PR introduce a breaking change?
Other information
All element titles (and stereotypes) wrap on long lines by default now. This may have some effect when a model is opened on a different OS, since there are different default fonts used. Should there be elements who's name is not line-wrapped by default?
Special thanks to @ghillebrand for suggesting a CSS based solution.