Replace deprecated Gtk.TreeView with ListView: Activity Parameter Nodes #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
changed the title
Show works, now edit, addition, removal, and reordering.
amolenaar
force-pushed
the
listview
branch
2 times, most recently
from
47bf0db
to
b51782a
Compare
|
This PR now has replaced the activity parameter property page with a new style list view. I think it reached feature parity, with keybindings and easy-adding features in place. Let's do the other TreeView's via different PR's, so we can keep the change manageable. |
amolenaar
changed the title
danyeaw
approved these changes
Jun 14, 2023
3 tasks
danyeaw
added a commit
that referenced
this pull request
Jul 8, 2023
Revert #2329 - Gtk.ListVew for Parameters
danyeaw
added a commit
that referenced
this pull request
Dec 22, 2023
Reapply #2329 - Gtk.ListView for Activity Parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Gtk.TreeViewis deprecated. GTK 4 has a much nicer tree widget:Gtk.ListVIew. It's already used for the model browser. We should also use it in the property editor, for both consistency and ease of use.Issue: #2231
Does this PR introduce a breaking change?
Other information
Gtk.ListViewhas no header. This will be introduced in GTK 4.12. So we may want to postpone changing toListViews.