Remove unused code (rational classes of perm groups) #886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some code that was unused since at least July 2005. Back then, @hulpke commented it out in the CVS repository. Two relevant quotes by him:
and
Based on some comments in the code, as well as "git blame", I think this code was originally written by Heiko Theißen. Perhaps it is meant to be faster for computing rational classes of perm groups -- but the fact that it hasn't been used for over a decade leads me to think we are better of removing it (I spent some time today trying to understand parts of this code, until I figured out it wasn't actually used).
If anybody wants to resurrect and fix it in the future: It'll still be available in the history... :)