Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeakPointer: Check for exclusive write access in LengthWPObj #78

Merged

Conversation

markuspf
Copy link
Member

  • As per Reimer's suggestion check for exclusive write access in
    LengthWPObj.
  • If we have write access, we discard objects at the end of the
    list, otherwise we just return the stored length.

* As per Reimer's suggestion check for exclusive write access in
  LengthWPObj.
* If we have write access, we discard objects at the end of the
  list, otherwise we just return the stored length.
@markuspf
Copy link
Member Author

@rbehrends is this ok? I realised the patch might be overly complicated, one could just put the following at the beginning of the function.

if(!CheckExclusiveWriteAccess(wp) {
  return STORED_LEN(wp);
}

@mohamed-barakat mohamed-barakat added topic: HPC-GAP Issues and PRs related to HPC-GAP gapdays2015-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2015-spring labels Mar 18, 2015
@rbehrends
Copy link
Contributor

Both should work, as far as I can tell.

markuspf added a commit that referenced this pull request Mar 18, 2015
WeakPointer: Check for exclusive write access in LengthWPObj
@markuspf markuspf merged commit 8fa7630 into gap-system:hpcgap-default Mar 18, 2015
@markuspf markuspf deleted the hpcgap-fix-wpobj-length branch October 26, 2015 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gapdays2015-spring Issues and PRs that arose at https://www.gapdays.de/gapdays2015-spring topic: HPC-GAP Issues and PRs related to HPC-GAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants