Fix a bug that could lead to ConjugacyClassesSubgroups to return wrong results when applied to permutation groups
#5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix conjugacy order and use correct partial stabilizers: First Union of orbits of same length, then same Orbits of same length Also ensure the output is of consistent format: Representatives are chossen from original list, if normalizer tests have been done other elements are conjugated to the same. Added assertions to test all conditions.
fingolfin
added
kind: bug
hulpke
approved these changes
Apr 13, 2025
fingolfin
added a commit
that referenced
this pull request
Apr 16, 2025
Fix conjugacy order and use correct partial stabilizers: First Union of orbits of same length, then same Orbits of same length Also ensure the output is of consistent format: Representatives are chossen from original list, if normalizer tests have been done other elements are conjugated to the same. Added assertions to test all conditions. Co-authored-by: Alexander Hulpke <hulpke@math.colostate.edu>
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix conjugacy order and use correct partial stabilizers: First Union of orbits of same length, then same Orbits of same length
Also ensure the output is of consistent format:
Representatives are chossen from original list, if normalizer tests have been done other elements are conjugated to the same.
Added assertions to test all conditions.
Fixes #5981
This fix is due to @hulpke I merely cherry-picked it into a PR.