Some GAC cleanup #5886
Merged
Some GAC cleanup #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
ChrisJefferson
approved these changes
Jan 4, 2025
It is undocumented and nothing calls it. There used to be a file `lib/compiler.g` that wrapped it, but that code also was undocumented and not used by anything, so we removed it in 2018.
... by having the comments generated for them be faithful to the source code, just like for all other statements.
When coding functions we already ensure there is a final `return` statement in there, so there is no need for gac to add yet another.
fingolfin
force-pushed
the
mh/compiler-magic
branch
from
79a1893 to
d89dff3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be best to not squash-merge this but rather preserve the individual commits via rebase or merge.