Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for recent gaplint #5785

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Update for recent gaplint #5785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 4 additions & 38 deletions .gaplint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,38 +1,4 @@
disable:
- W001
- W002
- W003
- W004
- W005
- W006
- W008
- W009
- W010
- W011
- W012
- W013
- W014
- W015
- W016
- W018
- W019
- W020
- W021
- W022
- W023
- W024
- W025
- W026
- W027
- W028
- W029
- W030
- W031
- W032
- W033
- W034
- W035
- W036
- W037
- W038
- W039
enable:
- analyse-lvars
- tabs
- trailing-whitespace
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ jobs:
with:
python-version: '3.10'
- name: "Install gaplint with pip"
run: pip install gaplint==1.1.5
run: pip install gaplint==1.3.2
- name: "Run gaplint lib/*.g* hpcgap/lib/*.g* grp/*.g lib/hpc/*.g hpcgap/lib/hpc/*.g . . ."
run: gaplint lib/*.g* hpcgap/lib/*.g* grp/*.g lib/hpc/*.g hpcgap/lib/hpc/*.g
3 changes: 1 addition & 2 deletions lib/grpfp.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# gaplint: disable = analyse-lvars
#############################################################################
##
## This file is part of GAP, a system for computational discrete algebra.
Expand Down Expand Up @@ -3980,7 +3979,7 @@ end);
##
InstallGlobalFunction(IsomorphismPermGroupOrFailFpGroup,
function(arg)
local mappow, G, max, p, gens, rels, comb, i, l, m, H, HH, t, gen, sz,
local mappow, G, max, p, gens, rels, comb, i, l, m, H, HH, t, sz,
t1, bad, trial, b, bs, r, nl, o, u, rp, eo, rpo, e, e2, sc, j, z,
timerFunc,amax,iso,useind;

Expand Down
3 changes: 1 addition & 2 deletions lib/kbsemi.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
## This file contains code for the Knuth-Bendix rewriting system for semigroups
## and monoids.
##
# gaplint: disable = analyse-lvars

InstallGlobalFunction(EmptyKBDAG,function(genids)
local offset,deadend;
Expand Down Expand Up @@ -876,7 +875,7 @@ end);

BindGlobal("GKB_MakeKnuthBendixRewritingSystemConfluent",
function(kbrws)
local pn,lp,rl,p,i,a;
local pn,lp,rl,p,i;

if IsBound(kbrws!.invmap) then
kbrws!.fellowTravel:=[];
Expand Down
Loading