Improve the dev/ci.sh script, make it usable interactive, and some related CI tweaks
#5567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: tests
fingolfin
force-pushed
the
mh/ci-test-cleanup
branch
2 times, most recently
from
50b2730 to
53b9832
Compare
This was referenced Jan 9, 2024
Merged
ChrisJefferson
approved these changes
Jan 10, 2024
|
OK, then I assume #5570 is also good -- let's merge that first (if you approve?), then rebase this PR -- then this PR here is 95% about making |
fingolfin
force-pushed
the
mh/ci-test-cleanup
branch
from
53b9832 to
8614809
Compare
... as part of the makemanuals test suite
... not via TEST_SUITES env var; that makes it more convenient to use this script interactively
The gap_cover_arg helper ensures uniform naming of the coverage files, always involving the name of the test suite, to reduce the chance of one overwriting outputs of the others. The testexpect testsuite actually did that, which is now also fixed.
... instead of expecting to be told the prefix via some environment variable.
For debugging it can be helpful to see the compilation commands in CI tests
fingolfin
force-pushed
the
mh/ci-test-cleanup
branch
from
8614809 to
4a81523
Compare
fingolfin
changed the title
tst, and improve the dev/ci.sh scriptdev/ci.sh script, make it usable interactive, and some related CI tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular
dev/ci.shis now very convenient to use interactively so one can easily replicate what certain CI tests do.Also fix a bunch of minor issues with CI and the tests here and there.
It may be best to review this commit-by-commit.
Resolves #1740
Resolves #4167