Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change assertion level in START_TEST and STOP_TEST. #549

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't change assertion level in START_TEST and STOP_TEST. #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af804a
Don't change assertion level in START_TEST and STOP_TEST.
stevelinton Jan 28, 2016
ea72108
Remove an assertion that leads to infinite recursion.
stevelinton Jan 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/matrix.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,8 @@ BindGlobal( "Matrix_CharacteristicPolynomialSameField",
vec[i] := zero;
fi;
od;
Assert(3, IsZero(Value(cp,imat)));
# Assert(3, IsZero(Value(cp,imat))); We can't do this because Value involves powering
# which uses the CharacteristicPolynomial
Assert(2, Length(CoefficientsOfUnivariatePolynomial(cp)) = n+1);
Info(InfoMatrix,1,"Characteristic Polynomial returns ", cp);
return cp;
Expand Down
6 changes: 0 additions & 6 deletions lib/profile.g
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,10 +1076,6 @@ START_TEST := function( name )
GASMAN( "collect" );
GAPInfo.TestData.START_TIME := Runtime();
GAPInfo.TestData.START_NAME := name;
GAPInfo.TestData.AssertionLevel:= AssertionLevel();
if GAPInfo.TestData.AssertionLevel < 2 then
SetAssertionLevel( 2 );
fi;
end;

STOP_TEST := function( file, fac )
Expand All @@ -1096,8 +1092,6 @@ STOP_TEST := function( file, fac )
else
Print( "GAP4stones: infinity\n" );
fi;
SetAssertionLevel( GAPInfo.TestData.AssertionLevel );
Unbind( GAPInfo.TestData.AssertionLevel );
Unbind( GAPInfo.TestData.START_TIME );
Unbind( GAPInfo.TestData.START_NAME );
end;
Expand Down