Fix an error in calculating subgroup lattices of nonsolvable groups was fixed. This error could lead to subgroups being omitted. #5475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulpke
added
kind: bug: wrong result
hulpke
force-pushed
the
additions
branch
2 times, most recently
from
c117084
to
32b3a6b
Compare
This fixes an error in finding the perfect subgroups which got introducted with a recent newer method. If the perfect residuum is too large, it now recurses to maximal subgroups Also fixed name of tst file (that was erraneously named txt)
hulpke
force-pushed
the
additions
branch
2 times, most recently
from
3de7b02
to
044b391
Compare
fingolfin
changed the title
fingolfin
added
release notes: use title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error in finding the perfect subgroups and removes the error case for larger groups by recursing through maximal subgroups.
Also fixed name of .tst file (that was erroneously named .txt)
Text for release notes
An error in calculating subgroup lattices of nonsolvable groups was fixed. This error could lead to subgroups being omitted.