Fix AbelianGroup to (better) handle empty order lists, and generators of order 1
#5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support `AbelianGroup( IsPermGroup, [] )` and `AbelianGroup( IsFpGroup, [] )` - changed the output of `AbelianGroup( IsPcGroup, ints )` such that also generators of order 1 appear
ThomasBreuer
added
kind: bug
fingolfin
approved these changes
Apr 5, 2023
| @@ -32,7 +32,7 @@ InstallMethod( AbelianGroupCons, "fp group", true, | |||
| function( filter, ints ) | |||
| local f,g,i,j,rels,gfam,fam; | |||
|
|
|||
| if Length(ints)=0 or not ForAll( ints, x -> IsInfinity(x) or (IsInt(x) and x >= 0) ) then | |||
| if not ForAll( ints, x -> IsInfinity(x) or (IsInt(x) and x >= 0) ) then | |||
| Error( "<ints> must be a list of integers" ); | |||
There was a problem hiding this comment.
Off-topic (not a change request, but perhaps we can some day address it): I guess strictly speaking this error is not accurate (as we allow infinity these days).
fingolfin
changed the title
AbelianGroup w.r.t. generators of order 1AbelianGroup to support empty order lists, and better handle generators of order 1
fingolfin
changed the title
AbelianGroup to support empty order lists, and better handle generators of order 1AbelianGroup to (better) handle empty order lists, and generators of order 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbelianGroup( IsPermGroup, [] )andAbelianGroup( IsFpGroup, [] )AbelianGroup( IsPcGroup, ints )such that also generators of order 1 appearresolves #5430