Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workspaces to save and restore "early methods" of operations #5400

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

ChrisJefferson
Copy link
Contributor

When earlyMethods were added, they were not added to the save / load workspace functions, so they were lost when a workspace is loaded.

Allows #5396 to work when a workspace is saved then loaded.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them topic: kernel labels Mar 9, 2023
@fingolfin
Copy link
Member

Ouch! Good catch. Early methods are in GAP 4.12.x, and nobody seems to have noticed so far. Probably because it is only use for matrix obj methods nobody really uses (yet), and for First, which has fallback methods that can do the job -- so it'd be slower in a restored workspace, but not unusable.

I'll mark this as "backport", just in case we make a 4.12.3 release before 4.13.0 (right now I have no plans to do that, but who knows...)

@fingolfin fingolfin changed the title Save and Load earlyMethods of operations Save and restore "early methods" of operations in workspaces Mar 9, 2023
@fingolfin fingolfin added backport-to-4.12 release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Mar 9, 2023
@fingolfin fingolfin changed the title Save and restore "early methods" of operations in workspaces Fix workspaces to save and restore "early methods" of operations Mar 9, 2023
@fingolfin fingolfin merged commit 9c55b89 into gap-system:master Mar 9, 2023
@ChrisJefferson ChrisJefferson deleted the fixearlymethods branch December 18, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants