Fix AsSet and other functions for GL(1,Integers) and SL(1,Integers)
#5245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: library
release notes: use title
hulpke
approved these changes
Dec 13, 2022
fingolfin
changed the title
AsSet and other methods for GL(1,Integers) and also SLGL(1,Integers) and SL(1,Integers) are finite
fingolfin
changed the title
GL(1,Integers) and SL(1,Integers) are finiteAsSet and other functions for GL(1,Integers) and SL(1,Integers)
fingolfin
added
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5239
Probably not the "right" fix (the default nice monomorphism shouldn't use
Enumerator(Rationals^1)but I couldn't figure out why that happens, so this was the quickest way to fix those two cases.