Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests that libgap works correctly with kernel modules - draft #5234

Closed
wants to merge 1 commit into from

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Dec 1, 2022

as a test, we load IO package - assuming it was built so that its kernel module is created.

That was missing, and caused a regression reported in #5232

When done, this PR will allow testing for the latter issue - which needs to be fixed elsewhere.

as a test, we load IO package - assuming it was built
so that its kernel module is created.

That was missing, and caused a regression reported in
gap-system#5232
@dimpase dimpase changed the title tests that libgap works correctly with kernel modules tests that libgap works correctly with kernel modules (draft Dec 1, 2022
@dimpase dimpase changed the title tests that libgap works correctly with kernel modules (draft tests that libgap works correctly with kernel modules - draft Dec 1, 2022
@dimpase dimpase added the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Dec 1, 2022
@dimpase
Copy link
Member Author

dimpase commented Dec 1, 2022

this most probably will need a tweaking of Makefile.rules

@dimpase dimpase added the topic: tests issues or PRs related to tests label Dec 1, 2022
@dimpase dimpase marked this pull request as draft December 1, 2022 13:30
@dimpase
Copy link
Member Author

dimpase commented Dec 1, 2022

@fingolfin - how can we make sure in Makefile.rules (?) that io is installed for this test?

@dimpase dimpase removed the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Dec 1, 2022
@fingolfin
Copy link
Member

Thanks, it is a good idea to test that kernel extensions work with libgap.

Indeed, we already test that, as part of the testmakeinstall CI test, which runs make install, then builds mockpkg against that and tries loading it.

This PR however tests for something else: it builds a package against a non-installed gap (which is not using libgap) and then tries to load it in a separate binary which does use libgap. There is no promise whatsoever that this works, and so this is not supported, even though it currently may work in some setups (but this may change in the future).

@fingolfin fingolfin closed this Dec 1, 2022
@dimpase
Copy link
Member Author

dimpase commented Dec 1, 2022

it builds a package against a non-installed gap (which is not using libgap) and then tries to load it in a separate binary which does use libgap.

Do you say that io.so is somehow made aware of libgap if it's built against gap linked to libgap ?

I don't understand why io.so is really different from a "usual" dylib that may be loaded by any
other dylib or executable that knows how to do it?
Both gap and libgap know how to load dynamic kernel modules, so it should not matter how exactly io.so is built, with gap linked to libgap, or with gap not linked to libgap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: tests issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants