buildsys: link installed gap executable against libgap and set SYS_DEFAULT_PATHS #5193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: build system
release notes: not needed
fingolfin
force-pushed
the
mh/installed-gap-with-libgap
branch
from
032a2a1 to
143b7f4
Compare
fingolfin
changed the title
fingolfin
force-pushed
the
mh/installed-gap-with-libgap
branch
2 times, most recently
from
54a85cc to
5c57a0f
Compare
When doing `make install`, install a version of GAP that links against libgap. Also adjust the installed sysinfo.gap accordingly.
Also change installed $bindir/gap from a wrapper shell script to a genuine binary (which works thanks to SYS_DEFAULT_PATHS being set)
fingolfin
force-pushed
the
mh/installed-gap-with-libgap
branch
from
5c57a0f to
ecd066f
Compare
|
I don't think anyone is likely to review this, so I'll just merge it. |
This was referenced Dec 2, 2022
well, why, we're always happy to review stuff related to using GAP in Sage... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
make install, install a version of GAP that links against libgap. That gap hasSYS_DEFAULT_PATHSset to point to the GAP roots$prefix/lib/gapand$prefix/share/gap. Also adjust the installed sysinfo.gap accordingly.Resolves #5096