Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DecomposeTensorProduct to ensure it produces a *sorted* list of highest weights, and document this #5158

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Change DecomposeTensorProduct to ensure it produces a *sorted* list of highest weights, and document this #5158

merged 1 commit into from
Oct 26, 2022

Conversation

wagh
Copy link
Contributor

@wagh wagh commented Oct 21, 2022

Optimisation in a loop running within DecomposeTensorProduct

  • This now returns sorted lists of weight vectors and the corresponding multiplicities
  • Added a test case for DecomposeTensorProduct

@fingolfin fingolfin added the gapdays2022-summer Issues and PRs that arose at https://www.gapdays.de/gapdays2022-summer label Oct 21, 2022
fingolfin
fingolfin approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

lib/lierep.gi Outdated Show resolved Hide resolved
@wagh @fingolfin
Modified DecomposeTensorProduct to optimise computations
143300b 
This now returns a sorted list of weight vectors
@fingolfin fingolfin enabled auto-merge (rebase) October 26, 2022 20:33
@fingolfin fingolfin changed the title Optimisation in DecomposeTensorProduct Change return value of DecomposeTensorProduct to be sorted Oct 26, 2022
@fingolfin fingolfin changed the title Change return value of DecomposeTensorProduct to be sorted Change list of highest weights returned by DecomposeTensorProduct to be sorted Oct 26, 2022
@fingolfin fingolfin changed the title Change list of highest weights returned by DecomposeTensorProduct to be sorted Change DecomposeTensorProduct to ensure it produces a *sorted* list of highest weights Oct 26, 2022
@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Oct 26, 2022
@fingolfin fingolfin changed the title Change DecomposeTensorProduct to ensure it produces a *sorted* list of highest weights Change DecomposeTensorProduct to ensure it produces a *sorted* list of highest weights, and document this Oct 26, 2022
@fingolfin fingolfin merged commit bb27ae1 into gap-system:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
gapdays2022-summer Issues and PRs that arose at https://www.gapdays.de/gapdays2022-summer kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagh @fingolfin