Backports for stable-4.12 #5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We stopped shipping this some time ago, as it was (a) outdated and (b) the FSF asked us to. So don't claim we ship them, instead point to a better alternative.
This section was partially outdated (reference to spaces in paths is hopefully obsolete?) and in general seems of little use these days, seeing as it mostly just recommends to use the .exe installer, which we recommend anyway... Also removing some trailing bits at the end of `INSTALL.md` which may or may not be supposed to be part of the remove section, but which seem out of place in any case.
This disables an attempt to use cyclic extension instead of lifting for lattices of smallish groups. The issue is that CE returns data in a slightly different format than required. This resulted in some commands, e.g. `ConjugacyClassesSubgroups(SmallGroup(1344,11293))`, to enter a break loop. If tomlib is loded it's a mote issue, and thus does not merit further investigation. This resolves gap-system#4854
Since this is costly, it is worth to force a minimal generating set for solvable groups. This resolves problems the yangbaxter package has had. Close gap-system#5024
fingolfin
added
the
release notes: not needed
fingolfin
requested review from
ChrisJefferson,
olexandr-konovalov,
wilfwilson and
wucas
…oups It could end up returning nothing and not invoking TryNextMethod(). This caused a failure in the hap test suite. This is a recent regression in 4.12.0.
ChrisJefferson
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AllHomomorphismClassesand possibly other code searching isomorphisms #5032ConjugacyClassesSubgroups#5033Centrefor pc groups giving wrong results, e.g.Size(Center(SmallGroup(2^9,261648)))gave 4 instead of 8 #5036MinimalGeneratingSetfor solvable non-pc groups #5041Note to self: Once this is merged, update the labels of those PRs.