Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and enforce that "nice monomorphisms" must have IsInjective set (otherwise an infinite recursion can happen) #5029

Merged
merged 4 commits into from
Sep 6, 2022
Merged

Document and enforce that "nice monomorphisms" must have IsInjective set (otherwise an infinite recursion can happen) #5029

merged 4 commits into from
Sep 6, 2022

Commits on Sep 5, 2022

  1. SetNiceMonomorphism requires HasIsInjective 

    This addresses issue gap-system#5020.
We check whether the map that shall be set as nice monomorphism
has already the `IsInjective` flag, and signal an error if not.
    @ThomasBreuer
    ThomasBreuer committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    61e94e2 View commit details
    Browse the repository at this point in the history

  2. set injectivity flag before calling SetNiceMonomorphism

    @ThomasBreuer
    ThomasBreuer committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    8dd99f1 View commit details
    Browse the repository at this point in the history

  3. set IsInjective in one more place 

    `MultiActionsHomomorphism` does not know about injectivity,
but since it is called with the `SeedFaithfulAction` data,
we can safely set the flag for the returned map.
    @ThomasBreuer
    ThomasBreuer committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    0a2378f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. addressed some comments

    @ThomasBreuer
    ThomasBreuer committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    d06e3b0 View commit details
    Browse the repository at this point in the history