Remove support for static linking from gac, it was rarely if ever used but required a disproportionate amount of effort to keep it working
#4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has virtually no use case anymore since dynamic linking is supported everywhere. At the same time it is an impediment for `make install` support. So it just doesn't seem worth the effort to preserve it.
fingolfin
added
the
release notes: use title
ChrisJefferson
approved these changes
Feb 19, 2022
|
I agree that static linking was useful in the past, but (hopefully) isn't going to be required in the future. |
frankluebeck
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Static linking was very useful for some time to produce portable binaries (e.g., for the old version of the GAP rsync-distribution). But this doesn't work reasonably well for some years.
So, I agree with removing the support for static linking.
The code changes look ok to me.
fingolfin
changed the title
gac, it was rarely if ever used but required a disproportionate amount of effort to keep it working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has virtually no use case anymore since dynamic linking is supported
everywhere. At the same time it is an impediment for
make installsupport.So it just doesn't seem worth the effort to preserve it.