Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up the linear algebra part of character table calculations for (large) groups #4773

Merged
merged 6 commits into from
Mar 2, 2022
Merged

Speed up the linear algebra part of character table calculations for (large) groups #4773

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1bd112
PositionNonZero for vector objects
hulpke Feb 16, 2022
f65e003
ENHANCE Methods for matrix objects
hulpke Feb 16, 2022
ce880cf
ENHANCE: Matrix objects for ZmodnZ
hulpke Feb 16, 2022
5eaa5a4
ENHANCE: Use matrix objects in Dixon-Schneider
hulpke Feb 16, 2022
eec16ca
Test and changes in test output and examples
hulpke Feb 16, 2022
e689844
HACK: Rank method higher than in package
hulpke Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
HACK: Rank method higher than in package 
The semigroups package has a method for `Matrix` that causes problems.
  • Loading branch information
@hulpke
hulpke committed Mar 2, 2022
commit e6898446bc6a89e48c9ed37c3be18cb637ac005e
4 changes: 4 additions & 0 deletions lib/matobj.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,10 @@ InstallMethod( Matrix,

InstallMethod( Matrix,
[ IsSemiring, IsList ],
# rank higher than a method in the semigroups package, which otherwise jumps
# in and causes an error when testing
# line 318 of semigroups-3.4.0/gap/elements/semiringmat.gi
20,
Comment on lines +300 to +303
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll have to sort it out together with the Semigroups folks, though, don't want to break that package (paging @james-d-mitchell).

function( R, list )
if Length(list) = 0 then
Error( "list must be not empty" );
Expand Down