Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn IsLexicographicallyLess into an obsolete synonym for \< #4504

Merged
merged 2 commits into from
May 21, 2021
Merged

Turn IsLexicographicallyLess into an obsolete synonym for \< #4504

merged 2 commits into from
May 21, 2021

Conversation

fingolfin
Copy link
Member

Because < already compares lists lexicographically, just
more efficiently than what IsLexicographicallyLess did.

The one downside of this I can think of is now one could
abuse this to write IsLexicographicallyLess(1,2)

As far as I can tell, no package and no library code uses IsLexicographicallyLess after this PR. So perhaps we should mark it as obsolete, too?

@fingolfin
Turn IsLexicographicallyLess into synonym for \<
461ec0a 
Because \< already compares lists lexicographically, just
more efficiently than what `IsLexicographicallyLess` did.

The one downside of this I can think of is now one could
abuse this to write `IsLexicographicallyLess(1,2)`
@fingolfin fingolfin requested a review from ThomasBreuer May 20, 2021 13:38
ThomasBreuer
ThomasBreuer approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, \< is better than IsLexicographicallyLess. (One more advantage is that \< works also for non-dense lists.)
I do also second the idea to move IsLexicographicallyLess to the obsolete functionality, and to drop the manual entry.

@ChrisJefferson
Copy link
Contributor

I also agree with making it obsolete (but this could be merged first, then that)

@fingolfin
Copy link
Member Author

I've just added a commit making it obsolete

@wilfwilson wilfwilson added release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes topic: obsolete functionality labels May 21, 2021
@wilfwilson wilfwilson changed the title Turn IsLexicographicallyLess into synonym for \< Turn IsLexicographicallyLess into an obsolete synonym for \< May 21, 2021
@wilfwilson wilfwilson added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels May 21, 2021
@ThomasBreuer ThomasBreuer merged commit df2bac3 into gap-system:master May 21, 2021
@fingolfin fingolfin deleted the mh/IsLexicographicallyLess branch May 25, 2021 14:40
@fingolfin fingolfin added kind: removal or deprecation A feature was removed or deprecated / made obsolete and removed topic: obsolete functionality labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

@wilfwilson wilfwilson wilfwilson approved these changes

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

Assignees
No one assigned
Labels
kind: removal or deprecation A feature was removed or deprecated / made obsolete release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fingolfin @ChrisJefferson @wilfwilson @ThomasBreuer