Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python script to get an overview of changes with PyGithub #4277

Merged
merged 23 commits into from
Apr 1, 2021
Merged

Python script to get an overview of changes with PyGithub #4277

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f488610
Initial Python script to get an overview of changes with PyGithub
Feb 19, 2021
ba926fa
Pretty-printing of changes overview
danielrademacher Feb 19, 2021
4d43a96
Reset output files; Also documenting, TODOs, formatting
Feb 19, 2021
ee1dc76
Cache data locally to reduce calling GitHub API
Feb 19, 2021
7c8db17
Consistently use double quotes
Feb 19, 2021
f1579ef
Add timestamp when printing API capacity
Feb 19, 2021
e30d6fc
Check the date format and provide usage instructions
Feb 19, 2021
e0dde67
Use more appropriate headers instead of labels
Feb 19, 2021
ebf7296
Apply suggestions from code review by @fingolfin
alex-konovalov Feb 24, 2021
62b3286
Description of script and API capacity
danielrademacher Feb 24, 2021
293263a
Move release notes script and README to dev/releases
Mar 13, 2021
02fda8a
Move exiting with a non-zero code into usage()
Mar 13, 2021
5b5c033
Extend description in the comments
Mar 13, 2021
84b2abc
Use formatted string to print link to PR in markdown
Mar 19, 2021
44e77c8
Next version of generating release note script
Mar 20, 2021
67296e8
Add comment to explain the output
Mar 23, 2021
5ffbb16
Introduce pr_to_md(k, title) to print PR entry in markdown
Mar 23, 2021
8144905
Update and move description of `prs` where it is used first
Mar 23, 2021
053f592
More informative names for files and their variables
Mar 23, 2021
a3404fd
Switch to utils.initialize_github()
Mar 23, 2021
9b42c1a
Add check for "release notes: use title" label
Mar 23, 2021
525f0eb
Add "release notes: highlight" to priority list
Mar 23, 2021
a4dab98
Set date for the 4.11.2 chnages
Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add check for "release notes: use title" label 
We need to use both old "release notes: added" label and
the newly introduced in "release notes: use title" label
since both label may appear in GAP 4.12.0 changes overview.
  • Loading branch information
Alexander Konovalov committed Mar 23, 2021
commit 9b42c1a3094fca57bff249713259a54edcabe6a8
6 changes: 4 additions & 2 deletions dev/releases/generate_release_notes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,10 @@ def changes_overview(prs,startdate,rel_type):
unsorted_file.write("### Uncategorized PR" + "\n")
removelist = []
for k in prs:
#if not "release notes: use title" in item[2]:
if not "release notes: added" in prs[k]["labels"]:
# we need to use both old "release notes: added" label and
# the newly introduced in "release notes: use title" label
# since both label may appear in GAP 4.12.0 changes overview
if not ("release notes: added" in prs[k]["labels"] or "release notes: use title" in prs[k]["labels"]):
unsorted_file.write(pr_to_md(k, prs[k]["title"]))
removelist.append(k)
for item in removelist:
Expand Down