Disable automatic compression of .gz files in stable-4.11 again #4165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused a regression in PackageManager and possibly elsewhere; so it is not suitable for the stable-4.11 branch.
fingolfin
added
the
regression
|
Luckily we still have AppVeyor set up, so we are not completely without CI, even if this is incomplete. Anyway I also tested this change locally and it should be simple and safe enough... |
wilfwilson
approved these changes
Nov 7, 2020
fingolfin
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused a regression in PackageManager and possibly elsewhere; so it is not suitable for the stable-4.11 branch. To clarify: this feature was not in GAP 4.11.0, we just backported it there. This PR adjusts that backport: we retain the improved to reading .gz files, but not the new behavior for automatically compression every file whose name ends with .gz.
See also discussion in PR #4128