Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TextInputFileRaw and TextOutputFileRaw #4110

Closed
wants to merge 2 commits into from
Closed

Add TextInputFileRaw and TextOutputFileRaw #4110

wants to merge 2 commits into from

Conversation

ChrisJefferson
Copy link
Contributor

Add the ability to access files without compression, for packagemanager (and other users who might need this).

Needs some more tests before merging, checking if the naming / general design is reasonable / fixes the problem

@ChrisJefferson ChrisJefferson added the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Sep 4, 2020
@mtorpey
Copy link
Contributor

mtorpey commented Sep 5, 2020

Thanks for doing this, Chris! This should make problems in curlInterface/PackageManager fixable.

mtorpey
mtorpey approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@mtorpey mtorpey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Not sure why it's failing Travis checks, but as far as I'm concerned it could be merged.

fingolfin
fingolfin requested changes Sep 22, 2020
View reviewed changes
lib/streams.gd Outdated Show resolved Hide resolved
lib/streams.gd Outdated Show resolved Hide resolved
src/sysfiles.h Show resolved Hide resolved
@fingolfin
Copy link
Member

@ChrisJefferson ping? you might want to at least merge the fixes I suggested?

@ChrisJefferson @fingolfin
Apply suggestions from code review
a5023ed 
Co-authored-by: Max Horn <max@quendi.de>
@ChrisJefferson
Copy link
Contributor Author

Fixes applied, will be continued in #4128 , as I put this in gap-system/gap by accident.

@ChrisJefferson ChrisJefferson deleted the raw-file branch October 8, 2020 15:37
@ChrisJefferson ChrisJefferson mentioned this pull request Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin requested changes

@mtorpey mtorpey mtorpey approved these changes

Assignees
No one assigned
Labels
do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisJefferson @mtorpey @fingolfin