Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance NormalClosure to accept a list of normal generators (instead of a group) as second argument #4000

Merged
merged 1 commit into from
May 6, 2020
Merged

Enhance NormalClosure to accept a list of normal generators (instead of a group) as second argument #4000

merged 1 commit into from
May 6, 2020

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Apr 30, 2020
PaulaHaehndel
PaulaHaehndel reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@PaulaHaehndel PaulaHaehndel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't want to document it, I'm fine with this added method and tests.
Thank you.

lib/grp.gi Outdated Show resolved Hide resolved
PaulaHaehndel
PaulaHaehndel approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@PaulaHaehndel PaulaHaehndel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing and documenting it and for the tests.
I'm fine with it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 84.372% when pulling 51d0b3b on fingolfin:mh/NormalClosure into 7b14c09 on gap-system:master.

@fingolfin fingolfin merged commit 63d2b80 into gap-system:master May 6, 2020
@fingolfin fingolfin deleted the mh/NormalClosure branch May 6, 2020 23:15
@ThomasBreuer ThomasBreuer self-assigned this Feb 16, 2021
@ThomasBreuer ThomasBreuer added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 16, 2021
@ThomasBreuer ThomasBreuer removed their assignment Feb 16, 2021
@olexandr-konovalov olexandr-konovalov mentioned this pull request Feb 19, 2021
Closed
@olexandr-konovalov olexandr-konovalov mentioned this pull request Mar 23, 2021
Merged
@fingolfin fingolfin changed the title NormalClosure: accept list of normal generators as second argument Enhance NormalClosure to accept a list of normal generators (instead of a group) as second argument Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulaHaehndel PaulaHaehndel PaulaHaehndel approved these changes

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fingolfin @coveralls @PaulaHaehndel @ThomasBreuer