Add libtool versioning to libgap shared library #3933
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set up a libtool library version using the
current:revision:age
format employed by libtool (see the libtool manual for details). We
currently do not use the
revision
value and use 0 instead. To avoid anever increasing number of versions, the kernel version is derived from
the libtool versioning info as follow:
This provides the right semantics, provided we diligently follow the
rules for adjusting the values of
current
andage
during releases,as outlined in a comment in
configure.ac
.Closes #3928
We could backport this to stabe-4.11, but that creates a somewhat iffy situation, as technically it would break the ABI going from 4.11.0 to 4.11.1; something we promised not to do. Yet one of the people who specifically asked whether we guarantee ABI stability in the 4.11 series, namely Bill Allombert from Debian, apparently is suggesting on the GAP mailing list that we do just that (however, I should qualify that this is just my understanding of what he said -- I may have misunderstood and don't want to misrepresent him). While that is all good and fine, I am not sure how other people packaging GAP would like this (e.g. @jamesjer working Fedora packages). Right now I think I'd prefer if we did not backport this, and just tell upstream packagers who want to know that GAP 4.12 will use the library version 8, so they can set any lower value for GAP 4.11, should they want to.