-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow function-call syntax for general mappings. #3901
Conversation
This feels like an improvement to me. If we decided we really didn't want this, I'd still want to add a function which told people to use |
1e32f95
to
50b5664
Compare
50b5664
to
b49315c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many people have been confused by this in the past, and I got a question about this just a few weeks ago, so...
The one objection I can think of is that GAP actions are always right actions, and this syntax is a strictly speaking a syntax for left actions; i.e., we have x^(f*g) = (x^f)^g
but (f*g)(x) = g(f(x))
. But I think that's not a major issue; though it might be worthwhile to point this property out explicitly in the documentation.
Please rebase so that tests have a chance of running.
@fingolfin Agreed about a warning in the documentation -- added "do not merge" until I have a minute to add it |
Documentation warning added. |
... which had been introduced in pull request gap-system#3901
... which had been introduced in pull request #3901
#2006 Description
Inspired by a recent GAP Forum request. This PR allows a function-call like syntax for taking images of general mappings. Specifically
map( x )
is treated asImage( map, x)
whenevermap
is a general mapping.It's really just for comments. The change is just a couple of lines, plus tests and a note in the manual,
so it seemed better to demonstrate the idea before discussing, but I'd not wedded to it.
Text for release notes
Allows a function-call like syntax for taking images of general mappings.
Incorporates #3902 which should be addressed first.
If this pull request should be mentioned in the release notes,
please provide a short description matching the style of the GAP
CHANGES.md
file in the root directory.Further details
If necessary, please provide further details here.
Checklist for pull request reviewers
If your code contains kernel C code, run
clang-format
on it; thesimplest way is to use
git clang-format
, e.g. like this (don'tforget to commit the resulting changes):
usage of relevant labels
release notes: not needed
orrelease notes: to be added
bug
orenhancement
ornew feature
stable-4.X
add thebackport-to-4.X
labelbuild system
,documentation
,kernel
,library
,tests
runnable tests
lines changed in commits are sufficiently covered by the tests
adequate pull request title
well formulated text for release notes
relevant documentation updates
sensible comments in the code