Replace some uses of DeclareGlobalVariable/InstallValue #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
release notes: not needed
fingolfin
force-pushed
the
mh/reduce-InstallValue
branch
3 times, most recently
from
ea9a1d2 to
de80954
Compare
... and instead use BindGlobal.
fingolfin
force-pushed
the
mh/reduce-InstallValue
branch
from
de80954 to
53b64a1
Compare
fingolfin
requested review from
ChrisJefferson,
AnnaKDS,
wilfwilson and
wucas
ChrisJefferson
approved these changes
Jan 27, 2020
fingolfin
added a commit
to fingolfin/cryst
that referenced
this pull request
Jan 28, 2020
Instead just use BindGlobal. For motivation of this change, please see <gap-system/gap#3857>
fingolfin
added a commit
to gap-packages/cryst
that referenced
this pull request
Dec 1, 2020
Instead just use BindGlobal. For motivation of this change, please see <gap-system/gap#3857>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and instead use
BindGlobal.My ultimate goal would be to get rid of all uses if
InstallValue, though we might never attain that (and we couldn't remove it, or even mark it as obsolete, for quite some time anyway; lots of packages use it, though I've also started to submit patches which removes its use in packages, too).Why? Well, there is #1637 and more recently, I discovered that it violates an important invariant in GAP (which is even more important in HPC-GAP): It can end up replacing an immutable object with a mutable one. Actually, the worst part probably is that it really replaces an object, rewriting the innards of the object, which can lead to really weird stuff going on...
Anyway, in all the places changed by this PR, there really wasn't a good reason to use
InstallValueoverBindGlobal.